Remove another coverage test which causes problems. #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had removed one of the two coverage checks which prevents ath10k nodes working at large distances. Now remove the second test which is being triggered in some circumstances. I *think* it is unnecessarily restrictive for our use case and removing it wont make things worse.
Coverage is handled by modifying firmware state, and the driver stores the values the first time it is set. When we reset this state might be lost so it will be reloaded from the firmware. We set the coverage back to 0 so the reloaded value will be the default again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had removed one of the two coverage checks which prevents ath10k nodes working at large distances. Now remove the second test which is being triggered in some circumstances. I think it is unnecessarily restrictive for our use case. Removing it wont make things worse.