-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for group alert messages #890
Conversation
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
I have two suggestions. First, make the Alert Groups feature part of the "AREDN Alert Settings" category so they appear along with all of the other Alert Settings. Second, the grouping feature is actually a subset of Local Messages so they should be under that code section rather than appending them separately at the end. I'm attaching two files here: one shows the Alert Groups as part of the AREDN Alert Settings category, and the second shows what the entire aredn_message.sh script could look like with the groups as part of the Local Message section of code. I have tested both of these attached files on my Alert node and they work as you envisioned. |
Ah. I was not looking at the fields close enough. The category field I was thinking that it was a field name. The intention was to keep the setting with the other alert fields. I will get the category field updated to get it included in the alert section. Your screen capture off one of your nodes is precisely what I was envisioning also. Are there any GitHub actions out there that I can add to my fork to build the sysimage file so that I can install and test changes to insure that things are working? Actually with these changes the amount of updates are easy and I can go update one of my nodes (probably similar to what you did). It would be nice to have a way to generate the sysimage from a branch so that bigger changes can be tested easily. |
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
I have updated I have created aredn/documentation#273 for documenting this feature. |
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
@ab7pa I have completed the updates to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @hickey And thanks for the corresponding documentation update too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
These changes are to address the feature request that I put forward in #872.
At this point the changes are untested, but they appear that they would work. If it is possible to build an AREDN firmware from this branch, then I would be very happy to test the changes on one of my nodes to validate that the functionality is working.