Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember and reinstall packages after firmware upgrade #930

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

aanon4
Copy link
Contributor

@aanon4 aanon4 commented Sep 16, 2023

Remember what packages get installed by the user, and reinstall them on the next firmware upgrades.
Locally installed packages are stored and moved across with the upgrade.
It waits a couple of minutes after the upgrade to activate (so the network should have stablised).

Would be good to get some eyes on this to see how reliable it is.

@aanon4 aanon4 changed the title Remember and reinstall packages are firmware upgrade Remember and reinstall packages after firmware upgrade Sep 16, 2023
@aanon4 aanon4 merged commit 1708c49 into aredn:main Sep 16, 2023
@k1ky
Copy link

k1ky commented Sep 16, 2023

To be clear - this feature will begin to work for the next upgrade "after" N-20230916 is installed?

@ab7pa
Copy link
Contributor

ab7pa commented Sep 16, 2023

Yes, the "package_store" will be created after you install 20230916 + your extra packages. Once the package_store exists then it can be used by subsequent upgrades.

@k1ky
Copy link

k1ky commented Sep 16, 2023

This may be the "coolest" upgrade feature since the inception of the ability to upgrade tunneled nodes remotely! Great job!

@k1ky
Copy link

k1ky commented Sep 16, 2023

Looks like there may be an issue with 32MB device upgrades for this feature. NSM2 with IperfSpeed 0.8 installed upgrading from Nightly 0916 to 0916 doesn't seem to bring the package over. HAP and other 64MB devices seem to work fine. Should I open an issue or note in documentation as modules aren't recommended or supported on 32MB devices for this feature?

@aanon4
Copy link
Contributor Author

aanon4 commented Sep 16, 2023

There is no guarantee reloading packages will work as it depends on a lot of things, the network being stable at the moment this is happening being a major one. Much less likely to work on 32MB devices as they struggle (I may add some kind of retry to this at a later date - let's see how this does first).

And yes, if we dont already note this - and I thought we did on the admin page in red text - installing packages on 32M nodes is not a good idea.

@k1ky
Copy link

k1ky commented Sep 16, 2023

Copy that.

@ab7pa
Copy link
Contributor

ab7pa commented Sep 16, 2023

One great thing about any recent version of the firmware is that you do not need to use iPerfSpeed to test your throughput. The firmware already has the ability to do this without requiring any separate packages. (link to documentation explaining how to do this)

@k1ky
Copy link

k1ky commented Sep 16, 2023

I really like the GUI features in the 0.8 Iperfspeed, being able to select available nodes without having to "type" everything in.

@ab7pa
Copy link
Contributor

ab7pa commented Sep 16, 2023

The 32mb nodes and the docs both warn against installing extra stuff on low memory nodes.
2023-09-16_13-06

@ab7pa
Copy link
Contributor

ab7pa commented Sep 16, 2023

I really like the GUI features in the 0.8 Iperfspeed, being able to select available nodes without having to "type" everything in.

The GUI comes at a cost. I find that browser bookmarks work nicely.

@aanon4
Copy link
Contributor Author

aanon4 commented Sep 16, 2023

Some improvement: #932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants