Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix api when meshrf is disabled #99

Merged
merged 1 commit into from May 5, 2021
Merged

bugfix: fix api when meshrf is disabled #99

merged 1 commit into from May 5, 2021

Conversation

dman776
Copy link
Contributor

@dman776 dman776 commented May 5, 2021

fixes #98

@dman776 dman776 requested review from ae6xe and ab7pa May 5, 2021 16:29
ab7pa
ab7pa approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@ab7pa ab7pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on node with meshrf enabled and disabled. Works perfectly. Thanks, @dman776

@dman776 dman776 merged commit 209f9dc into aredn:main May 5, 2021
@dman776 dman776 deleted the lua_lib_meshrf_fix branch August 29, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ab7pa ab7pa ab7pa approved these changes

@ae6xe ae6xe Awaiting requested review from ae6xe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: api should handle nil device if meshrf is disabled
2 participants
@dman776 @ab7pa