Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planes defined by 3 points are not recognized #1

Closed
arekfu opened this issue Sep 18, 2019 · 1 comment
Closed

Planes defined by 3 points are not recognized #1

arekfu opened this issue Sep 18, 2019 · 1 comment
Assignees
@arekfu
Labels
enhancement New feature or request
Milestone
0.2.0

Comments

@arekfu
Copy link
Owner

arekfu commented Sep 18, 2019

We need to extend the conversion to handle the case of a plane defined by three points. In the MCNP input file, such planes are defined as

<surface_number> P <x1> y1> <z1> <x2> <y2> <z2> <x3> <y3> <z3>
@arekfu arekfu added the enhancement New feature or request label Sep 18, 2019
arekfu added a commit that referenced this issue Sep 19, 2019
@arekfu
Support conversion of planes defined by three points
ab6d7fd 
This commit fixes issue #1.
@arekfu arekfu added this to the 0.1.5 milestone Sep 19, 2019
@arekfu arekfu self-assigned this Sep 19, 2019
@arekfu arekfu closed this as completed Sep 23, 2019
@arekfu
Copy link
Owner Author

arekfu commented Oct 7, 2019

Geometrical transformations do not work.

@arekfu arekfu reopened this Oct 7, 2019
arekfu added a commit that referenced this issue Oct 14, 2019
@arekfu
Major refactoring of surface parsing and conversion
388ee18 
A side effect of this refactoring is that we treat parsed and
transformed surfaces in the same way, fixing issue #1 for real.
arekfu added a commit that referenced this issue Oct 16, 2019
@arekfu
Major refactoring of surface parsing and conversion
eb7e1de 
A side effect of this refactoring is that we treat parsed and
transformed surfaces in the same way, fixing issue #1 for real.
arekfu added a commit that referenced this issue Oct 21, 2019
@arekfu
Major refactoring of surface parsing and conversion
a97b1cf 
A side effect of this refactoring is that we treat parsed and
transformed surfaces in the same way, fixing issue #1 for real.
arekfu added a commit that referenced this issue Oct 25, 2019
@arekfu
Major refactoring of surface parsing and conversion
ed32705 
A side effect of this refactoring is that we treat parsed and
transformed surfaces in the same way, fixing issue #1 for real.
@arekfu arekfu closed this as completed Oct 30, 2019
arekfu added a commit that referenced this issue Feb 12, 2020
@arekfu
Fix parsing of consecutive complement operators (#1#2)
4b36ba7
arekfu added a commit that referenced this issue Feb 12, 2020
@arekfu
Fix parsing of consecutive complement operators (#1#2)
cb256ad
arekfu added a commit that referenced this issue Feb 12, 2020
@arekfu
Fix parsing of consecutive complement operators (#1#2)
14a41a5
arekfu added a commit that referenced this issue Feb 13, 2020
@arekfu
Fix parsing of consecutive complement operators (#1#2)
d36dcf7 
Closes issue #33.
arekfu added a commit that referenced this issue Feb 13, 2020
@arekfu
Fix parsing of consecutive complement operators (#1#2)
8bed9c4 
Closes issue #33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arekfu arekfu

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@arekfu