Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the conversion of elliptic tori #3

Closed
arekfu opened this issue Sep 18, 2019 · 1 comment
Closed

Handle the conversion of elliptic tori #3

arekfu opened this issue Sep 18, 2019 · 1 comment
Assignees
@arekfu
Labels
bug Something isn't working
Milestone
0.2.0

Comments

@arekfu
Copy link
Owner

arekfu commented Sep 18, 2019

Only circular tori are handled for the moment.
@arekfu arekfu added the bug Something isn't working label Sep 18, 2019
@arekfu arekfu added this to the 0.1.5 milestone Sep 19, 2019
@arekfu arekfu self-assigned this Sep 19, 2019
@arekfu
Copy link
Owner Author

arekfu commented Sep 19, 2019

OK, correction: elliptic tori are converted fine if no transformation is applied. When a transformation is applied, mip chokes on the torus with the following error:

Traceback (most recent call last):
[...]                                                                                                                                                                                                           
  File "/.../t4_geom_convert/t4_geom_convert/MIP/geom/forcad.py", line 397, in tz
    x, y, z, r1, r2 = _check_torus(p)
  File "/.../t4_geom_convert/t4_geom_convert/MIP/geom/forcad.py", line 373, in _check_torus
    raise NotImplementedError('Cannot convert torus with B != C')
NotImplementedError: Cannot convert torus with B != C

arekfu added a commit that referenced this issue Sep 23, 2019
@arekfu
Add support for elliptic tori in MIP (#3)
ef7fb42 
To be reported upstream.
@arekfu arekfu closed this as completed Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arekfu arekfu

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@arekfu