xmldsig is not working with unicode atributes

[IgorKarymov]

i got {error, bad_digest} in the case when assertion displayName was setted in "Игорь Карымов" value.
Actually i'm not sure that bug in esaml library because it's also possible that issue in simplesamlphp library (i use 1.8.2-1 version).

[arekinath]

I've tried to reproduce this and failed -- utf8 input seems to work as it should. Are you sure about exactly which encoding it's using? If it's not specified, xmerl will assume utf8 I believe, and baulk if it's anything else. We've had issues here in the past with SSP producing data that's a mix of different encodings (not all utf8), which breaks everything (even other SSP SPs)

[IgorKarymov]

Thanks for response.
I guess that issue not in esaml implementation (tests showed that it consistent)
but in interoperability with simplesamlphp.
Looks like simplesamlphp have another vision of how-to this kind of xml should be canonized. But how we can check this?
Here is xml response that was sended by simplesamlphp and our canonized version:
https://gist.github.com/IgorKarymov/6c0767043b28625b9627

Also string was correctly parsed by xmerl to:

{xmlText,
                   [{'saml:AttributeValue',1},
                    {'saml:Attribute',31},
                    {'saml:AttributeStatement',6},
                    {'saml:Assertion',4},
                    {'samlp:Response',1}],
                   1,[],
                   [1080,1075,1086,1088,1100,1082,1072,1088,1099,1084,1086,
                    1074],
                   text}

so i think issue not in encoding.

[arekinath]

some fixes in 9c5bf67 that seem to make the xml in the gist validate now

[arekinath]

I'm gonna close this after our conversation on IRC, sounds like this one is fixed