ADCM-1366 MultipleObjectsReturned on GET hc #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grey-kristy
suggested changes
Jul 20, 2020
python/api/cluster_serial.py
Outdated
| comp = Component.objects.get( | ||
| name=c['component'], | ||
| prototype__name=c['service'], | ||
| prototype__in=sp_qs # There is no way to do this without 'in' |
There was a problem hiding this comment.
may be
prototype__bundle_id=obj.prototypype.bundle_id
acmnu
force-pushed
the
ADCM-1366
branch
2 times, most recently
from
e28b764
to
51a78f3
Compare
There is a trouble with read operation of HC in cluster. That is an issue in ADCM-733 solution. In case we have more than one prototype of service with the same name in DB we have a trouble with searching exact component. There is no restriction per bundle. So we have MultipleObj exception on objects.get() operation. Solution is to restrict service prototypes to exactly one bundle.
grey-kristy
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a trouble with read operation of HC in cluster.
That is an issue in ADCM-733 solution.
In case we have more than one prototype of service with the
same name in DB we have a trouble with searching exact component.
There is no restriction per bundle. So we have MultipleObj
exception on objects.get() operation.
Solution is to restrict service prototypes to exactly one bundle.
That solution is not simple because we have no good ORM way to find
result over FK. We have to use SQL in operation, which not so offen in
use in our code.