ADBDEV-4618 Free tuple after use #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RekGRpth
reviewed
Dec 21, 2023
prevents |
refresh_rejectmap looked for an oid in local cache and retrieved a copy in a case of success. However, such a tuple should be freed after use, but refresh_rejectmap didn't do that which resulted in huge memory leak if there were passed lots of oid, which could result in diskquota stopping working. This patch frees these tuples and prevents memory leaks
dnskvlnk
force-pushed
the
ADBDEV-4618
branch
from
6b00323
to
94a7279
Compare
RekGRpth
previously approved these changes
Dec 25, 2023
|
@dnskvlnk , I'm ready to approve. Looks good. |
bimboterminator1
previously approved these changes
Dec 26, 2023
dnskvlnk
changed the title
dnskvlnk
dismissed stale reviews from bimboterminator1 and RekGRpth
via
0e0bf72
bimboterminator1
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refresh_rejectmap looks for a tuple using SearchSysCacheCopy1 which retrieves
a copy of the tuple allocating memory for it. However, refresh_rejectmap didn't
free these tuple copies after use. If lots of oids were passed, diskquota could
work incorrectly because of huge memory leak. This patch frees these tuples and
prevents memory leaks.