adapt to API changes of mirage-conduit (dns resolver now has a timeout) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuragsoni
approved these changes
May 12, 2020
|
Thanks! I'll land this once the new release of conduit is published on opam |
|
unfortunately the |
|
fwiw, conduit-mirage 2.2.0 is now part of opam-repository, and mirage 3.7.7 is PRed to opam-repository, thus this PR could very well be landed and a minor release of pgx-lwt-mirage be pushed to opam-repository :) |
anuragsoni
force-pushed
the
newer-mirage-conduit
branch
from
4acdf60
to
eba6b2e
Compare
|
Sorry this took some time. I took a couple of days off. I've synced the PR with changes in master and this should be ready to land after that. Thank you! |
anuragsoni
force-pushed
the
newer-mirage-conduit
branch
4 times, most recently
from
f73a7fe
to
10dd89a
Compare
anuragsoni
force-pushed
the
newer-mirage-conduit
branch
3 times, most recently
from
5357bdc
to
e469622
Compare
anuragsoni
force-pushed
the
newer-mirage-conduit
branch
from
e469622
to
88fff78
Compare
brendanlong
approved these changes
May 20, 2020
|
Hello! Any ETA for a new release of |
samoht
added a commit
to samoht/mirage-skeleton
that referenced
this pull request
Jun 19, 2020
brendanlong
added a commit
to brendanlong/opam-repository
that referenced
this pull request
May 12, 2021
…x_lwt_unix, pgx_lwt and pgx (2.0) CHANGES: ### Breaking changes * The Pgx module is now wrapped, which means `Pgx_aux`, `Types`, `Access`, etc. aren't added to the global scope. The main result of this is that `Pgx_value` now needs to be accessed as `Pgx.Value`. (arenadotio/pgx#103) * `Pgx_async.connect` and `with_conn` now have an additional optional `?ssl` argument (see below). ### Added * Pgx_async now supports TLS connections using Conduit_async. This is enabled by default and can be controlled with the new `?ssl` argument to `connect` and `with_conn`. (arenadotio/pgx#108) ### Fixed * Improved message for authentication errors. Previously these raised `Pgx_eof`, and now they raise `PostgreSQL_Error("Failed to authenticate with postgres server", additional details ...)`. (arenadotio/pgx#105) ### Changed * Support new Mirage-conduit timeout argument (arenadotio/pgx#95).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be released in ocaml/opam-repository#16425