-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: /v2/spvp/matches #38
base: master
Are you sure you want to change the base?
Conversation
We're waffling on this one internally w.r.t how much data and under what situations it should be exposed publicly. It might be just Ranked matches exposed, or it might be some kind of in-game checkbox to opt into public data. Or it might just be API-key restricted see-your-data-only. Not yet sure. Dotabuff is roughly what we're using as a measuring stick. While we figure out what/how to make stuff public, I'm working on exposing your personal data via API key stuff. Figure I'll tuck it behind the {
"id": "0CCC6919-B871-4198-957B-6EBFE8C34114",
"map_id": 52,
"date": "2015-06-06T07:40:09.000Z",
"duration": 374.4,
"result": "victory",
"team": "red",
"profession": "mesmer",
"scores": {
"red": 0,
"blue": 501
}
} I think I'm probably going to swap out The way the data's currently structured it's hypothetically possible for a match to have more than two teams, so however unlikely that is to change, I put the Additionally, it may be better instead of In response to your questions:
I think it makes the most sense to put the character name (rather than account name) in there, despite the switching issue. It might make sense to put both. Rosters aren't currently exposed to the API layer by the backend, so will need to look into how that's gonna be hooked up w.r.t character switching. When rosters are exported, ideally I'd like to expose each player's character name, profession and build.
The current word is that we can't expose the internal matchmaking numbers (e.g., match predictions and account MMRs). Leaderboard ranks will likely be exposed at some point via a separate endpoint so you can query for them meaningfully.
Seems reasonable to me. The tough part is threading that data through all the bits and pieces, but I think we'll be able to have those bits in eventually. |
The things you propose look good! I didn't knew there already was a /v2/pvp/games API in development/released. I think the key point that will determine the API's usability is if Rosters will be exported with data on builds of the participants. The Ladder: "Ranked" is indeed a very good idea, I should have thought about that before. About Character Swapping: I wonder what would be the best approach for this. Normally players would only swap at the start of the game, so it might be an option of taking the character that was there when the game finished. But I guess that this is not waterproof. (Players could potentially abuse this and swap before the end of the game, to make people believe they won with a half-baked build) I really hope that the Rosters can become public, but I can understand that this is still in discussion. |
Lets hope you can figure #32 out and we get |
I have the mind of a goldfish; I just started plumbing the data through last week and neglected to write up the details. I also have
Ultimately, yeah. I'm pretty sure the initial release of this endpoint will be without roster/builds though; the match history this pulls from is fairly ephemeral (not sure what the current/planned configuration is -- IIRC it's just the 10 most recent matches stored), so I'd rather have a partial implementation sooner. The full implementation (with all the goodies) will arrive at a later date.
My understanding was that, once dishonor was enabled this would cause a match loss for the team (maybe that's the "forfeit" state?), but only in the ranked queue. Don't quote me on that though, might be mis-remembering. It's still a problem, but I'm not sure there's going to be a clean solution. We almost need play-by-play recountings of the entire match (e.g., skill usage log with locations + time indexes) in order to correlate it better. I have a feeling that might be a bit infeasible though, not sure.
#32 doesn't help you if |
So, I kinda feel that this is a minimal version of https://forum-en.guildwars2.com/forum/community/api/Proposal-Structured-PvP-API/first I don't have time to post it here, but hopefully linking this will help flesh this out with events and data. |
Yeah, the first release is going to be very minimalistic. It's just a limitation of what data we're currently piping through the system; it'll take some time and coordination to pull the rest through. Figured we'd put out what we've got now then continue to improve it. |
Hello everyone!,
First of all: I am a bit new to github so excuse me if I forgot to do something or did do something wrong.
Currently there is no way to retrieve information about matches of sPvP. This API would enable us to look into the matches played by players and against who.
A small example:
// GET /v2/spvp/matches?character=Charizard
Personally I'd rather have this to be an open API, so that you can also track the matches played by friends or opponents. So a list of a few issues we need to think about:
Issue's:
It would be nice if something like http://www.lolking.net/ could be created, where you can enter a players name, see the matches and ranking and view statistics about opponents too.