Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/v2/wvw/matches: add more objective fields. #397

Merged
merged 4 commits into from
Mar 1, 2017
Merged

/v2/wvw/matches: add more objective fields. #397

merged 4 commits into from
Mar 1, 2017

Conversation

lye
Copy link
Contributor

@lye lye commented Dec 3, 2016

  • points_capture/points_tick since points are variable now.
  • upgrades containing a list of slotted upgrades.

I'm not altogether happy with the output format, very open to suggestions.

Fixes #181; doesn't yet expose yaks needed for next tier.
Fixes #394.
Refs #118. Localized upgrade stuff (and the yaks/tier) needs to be added somewhere.

 * points_capture/points_tick since points are variable now.
 * upgrades containing a list of slotted upgrades.
@thetoothpick
Copy link

It'd be nice if you could expose the objective upgrade level (i.e. tier) in the "upgrades" key instead of guild upgrades, and move those to "guild_upgrades". You can calculate the level based on the number of yaks delivered, but those numbers aren't published in the API anywhere from what I can tell, and hardcoding them would be awkward.

Besides, guild upgrades are a separate concept from objective upgrades, and should be put in a separate key so people don't confuse them.

@lye
Copy link
Contributor Author

lye commented Jan 3, 2017

I think the yaks/upgrade bits need to go into /v2/wvw/objectives since there's some additional localized info for them (icons, names, etc) -- split out into #422.

@lye
Copy link
Contributor Author

lye commented Mar 1, 2017

Uhh, this went out a bit early and I kind of botched it (didn't get the upgrades -> guild_upgrades change).

I should do that real quick.

@lye lye merged commit 03742c0 into master Mar 1, 2017
@lye lye removed the needs deploy label Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants