Skip to content

Commit

Permalink
Revert "Fix SendMail watchdog restart during reconnect to SMTP serv…
Browse files Browse the repository at this point in the history
…er (#21454)"

This reverts commit 784bc3e.
  • Loading branch information
arendst committed May 22, 2024
1 parent 784bc3e commit a14aad9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ All notable changes to this project will be documented in this file.
- Webradio crash with invalid url (#21446)
- Zigbee crash when removing `ZbName` (#21449)
- ESP32 BLE fix scanning (#21451)
- `SendMail` watchdog restart during reconnect to SMTP server (#21454)

### Removed
- Support of old insecure fingerprint algorithm. Deprecated since v8.4.0 (#21417)
Expand Down
1 change: 0 additions & 1 deletion RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ The latter links can be used for OTA upgrades too like ``OtaUrl https://ota.tasm
- Wrong timeout in `WebQuery` and `webclient` since Core3 [#21442](https://github.com/arendst/Tasmota/issues/21442)
- Zigbee crash when removing `ZbName` [#21449](https://github.com/arendst/Tasmota/issues/21449)
- Avoid connection errors when switching to safeboot to upload OTA firmware [#21428](https://github.com/arendst/Tasmota/issues/21428)
- `SendMail` watchdog restart during reconnect to SMTP server [#21454](https://github.com/arendst/Tasmota/issues/21454)
- ESP32 BLE fix scanning [#21451](https://github.com/arendst/Tasmota/issues/21451)
- Webradio crash with invalid url [#21446](https://github.com/arendst/Tasmota/issues/21446)
- Berry Leds matrix alternate more and error about 'bri' attribute [#21431](https://github.com/arendst/Tasmota/issues/21431)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,6 @@ uint16_t SendMail(char *buffer) {

/* Connect to server with the session config */
delay(0);

smtp->closeSession(); // Fix watchdog due to long connection time (#21454)

if (smtp->connect(&session)) {
/* Start sending the Email and close the session */
delay(0);
Expand All @@ -267,8 +264,7 @@ uint16_t SendMail(char *buffer) {
}
}

if (smtp) { delete smtp;
}
if (smtp) { delete smtp; }
for (uint32_t cnt = 0; cnt < MAX_ATTCHMENTS; cnt++) {
if (attachments[cnt]) {
free(attachments[cnt]);
Expand Down

0 comments on commit a14aad9

Please sign in to comment.