-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS Failing since commit 63c7e5f7bfb886c6ce4318d744e0191f78a77204 #12031
Comments
Will take a look |
I can't reproduce. I suspect it's a wrong size for the ThunkStack that causes the crash. What are your compile options? |
I am surprised you don't see the problem. I can reproduce it every time. If I compile with the TLS setting and then configure MQTT checking the "USE TLS" box, it saves the settings, reboots and they you see the error above. I am using a nodeMCU ESP12E board. Is there any debug setting or change I can make to help troubleshoot? I am using Visual Studio Code on Windows to build. Here is my `platform_override.ini'.
|
Can you try to raise all values of '_stackSize' to 5300/4 here:
I suspect that the configuration is not well detected and a stack size too short would lead to a crash If it works, can you report the stack used from the logs? |
That was it! It looks like the stack was just a little under the limit, as shown by the info below
I will submit a small PR to address my use case. |
This addresses the issue arendst#12031
Sorry for bothering, but if using TLS with fingerprint, the stacksize of 3600 (line 49) in my case was to low either. So the value in the else case should also be raised. As you can see, my Thucksize used is:
I don't know, what the ideal value could be, in my case it is 3700 |
Thanks for the feedback, I have raised it to 3800 to have some headroom. |
Increase min stack thunk to 3800 #12031
PROBLEM DESCRIPTION
Ever since the TLS changes in 63c7e5f, it fails on NodeMCU.
REQUESTED INFORMATION
Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!
Backlog Template; Module; GPIO 255
:Backlog Rule1; Rule2; Rule3
:Status 0
:weblog
to 4 and then, when you experience your issue, provide the output of the Console log:TO REPRODUCE
Git checkout -f 63c7e5f7bfb886c6ce4318d744e0191f78a77204
#define USE_MQTT_TLS
to your user_config_override.h fileEXPECTED BEHAVIOUR
It worked in the prior commit: c398ce7
It continues to fail (has not been fixed) in the current: 3c4acc9
SCREENSHOTS
If applicable, add screenshots to help explain your problem.
ADDITIONAL CONTEXT
Add any other context about the problem here.
(Please, remember to close the issue when the problem has been addressed)
The text was updated successfully, but these errors were encountered: