Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuya data type 2 read as 32 bit integer (instead of 16 bit) #12282

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented Jun 3, 2021

Description:

This is a follow up on PR #12115 (and discussion #12114)
as discussed here #12272

PR12115 addressed only the case of Active_Power > 2 bytes, but Total_Power is also impacted.
After careful reading it doesn't seem a problem to always read a DpId type 2 as 4 bytes and make this a general case instead of specific.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 74a1150 into arendst:development Jun 3, 2021
@barbudor barbudor deleted the tuyamcu_total_power branch June 18, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants