Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ir panasonic esp8266 #18013

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Fix ir panasonic esp8266 #18013

merged 3 commits into from
Feb 21, 2023

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented Feb 21, 2023 •
edited
Loading

Description:

Related issue (if applicable): fixes #17677

Partially revert changes from @s-hadinger 's #16179 as it breaks some protocols on ESP8266

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • [x ] Only one feature/fix was added per PR and the code change compiles without warnings
  • [x ] The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.6
  • [x ] I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@barbudor barbudor mentioned this pull request Feb 21, 2023
Closed
14 tasks
@arendst arendst merged commit dbcffa6 into arendst:development Feb 21, 2023
@Jason2866
Copy link
Collaborator

@barbudor 👍
Can you add a short doc what changes are made in the lib against the original lib?
Helps not forget when updating.

ZioFabry pushed a commit to Biomine-Sustainable-Mining/Tasmota that referenced this pull request Feb 25, 2023
@barbudor @ZioFabry
Fix ir panasonic esp8266 (arendst#18013)
8aafb28 
* revert part of arendst#16179 for ESP8266

* Revert "revert part of arendst#16179 for ESP8266"

This reverts commit b8e6126.

* try to revert arendst#16179 for esp8266
mbronk pushed a commit to mbronk/Tasmota that referenced this pull request May 8, 2023
@barbudor @mbronk
Fix ir panasonic esp8266 (arendst#18013)
1d9cf40 
* revert part of arendst#16179 for ESP8266

* Revert "revert part of arendst#16179 for ESP8266"

This reverts commit b8e6126.

* try to revert arendst#16179 for esp8266
mbronk pushed a commit to mbronk/Tasmota that referenced this pull request May 8, 2023
@barbudor @mbronk
Fix ir panasonic esp8266 (arendst#18013)
59e6c26 
* revert part of arendst#16179 for ESP8266

* Revert "revert part of arendst#16179 for ESP8266"

This reverts commit b8e6126.

* try to revert arendst#16179 for esp8266
s-hadinger pushed a commit that referenced this pull request May 8, 2023
@mbronk @barbudor
IRremoteESP8266 upgraded to v2.8.5 (#18610)
faff39c 
* IRremoteESP8266 upgraded to v2.8.5 (from v2.8.4)

* Fix ir panasonic esp8266 (#18013)

* revert part of #16179 for ESP8266

* Revert "revert part of #16179 for ESP8266"

This reverts commit b8e6126.

* try to revert #16179 for esp8266

* Build: removed redundand USE_IR_REMOTE_FULL flag

Tasmota32-ir PIO had both FIRMWARE_IR and USE_IR_REMOTE_FULL defined.
The latter is redundand and yielded unnecessary build warns.
See: tasmota_configurations.h

---------

Co-authored-by: Mateusz Bronk <2566147+mbronk@users.noreply.github.com>
Co-authored-by: Barbudor <barbudor@barbudor.net>
@barbudor barbudor deleted the fox_ir_panasonic_esp8266 branch June 9, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tasmota 12.1.0 brakes IRSend repeat for Panasonic TVs
3 participants
@barbudor @Jason2866 @arendst