-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loss of energy total data by updating to 12.4.0 #18024
Comments
+1, exactly the same situation. |
same here |
Gents I need the requested information when you'all openend this issue. Without it would be guessing what's going on. |
It happens during a standard update. Installed was on most of my devices 12.0.2 DE |
Since v12.4.0 the internal energy totals representation should have been divided by 100 to accomodate larger total values. For a user this should have been "invisible". Tests we did indeed provided the expected results. What do you see if you set |
I think I know where it goes wrong. When a newer version tasmota is installed it checks if the version number has changed and if so performs settings changes supported by the newer version. In this case it performs the new energy total calculation in both settings AND RTC storage. The minimal version is supposed the be not updating settings and that works fine except this time I also made the energy total change in RTC memory which is now executed twice. Once by the minimal version and once by the final version. As I test without the intermediate minimal version I didn't see this double divide. I'll do some tests and will change the minimal version not to update both settings AND RTC storage. |
Fixed EnergyTotal divided twice during minimal upgrade step regression from v12.3.1.3 (#18024)
|
@arendst Did this bug only affected esp8266 devices? |
Not sure. I expect safeboot not to update the RTC but perhaps it's best I push the fix to master and generate new safeboot/factory images too. |
Done. It's now fixed in latest master release from February 24th for all binaries. |
Fixed EnergyTotal divided twice during minimal upgrade step regression from v12.3.1.3 (arendst#18024)
I agree, tested on multiple devices, it's fixed |
When updating from e.g. 12.0.2 or 12.3.1 to 12.4.0 the energy total value is lost. At low values the value is 0 after the update, at high values it is about 40 times smaller.
![Screenshot after update 2023-02-22 192556](https://user-images.githubusercontent.com/70629055/220723999-75226466-da97-4d23-a483-6b1985b2e17b.jpg)
![Screenshot before update 2023-02-22 192403](https://user-images.githubusercontent.com/70629055/220724007-5836a5a0-dc1b-415b-bcd9-bd75c25c3bcf.jpg)
![Screenshot after update 2023-02-22 193948](https://user-images.githubusercontent.com/70629055/220726475-21b80428-6af4-4da7-95ab-c25ff5a3ce84.jpg)
![Screenshot before update 2023-02-22 193626](https://user-images.githubusercontent.com/70629055/220726486-f93b1459-9786-4d67-8939-7cbfd24768db.jpg)
The text was updated successfully, but these errors were encountered: