-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for SPL06_007 Temperature & Pressure I2C (+10k2 code) #21185
Conversation
+10K seems a lot for this sensor. Can you find ways to reduce it? |
Removes -2kb
I can only get it down to roughly 10k for the library its self, the device has an odd amount of calibration values required, seems to be for accuracy and its speed at reading |
I think that the main problem is using |
Maybe im counting the size wrong? I was just adding up the size of the files in my file explorer, I don't see how changing a |
I tried on ESP8266, I only see 2.7KB increase. However you should still move to See https://tasmota.github.io/docs/Sensor-API/#floats-not-doubles We have been chasing down almost all For example: avoid |
I changed blindly all Can you please do those changes? |
Thx. In order to merge please change chosen sensor index 126 to it's final destination 25 |
Noticed an inconsistency in what feature flag bit is used. While According to the position, the expected bit should be |
Obvious "typo" in setting the feature bit for this recently added sensor. Already mentioned in arendst#21185 (comment)
Obvious "typo" in setting the feature bit for this recently added sensor. Already mentioned in #21185 (comment)
…rendst#21185) * Adds support for SPL06_007 (+10k2 code) * removes not so used methods. Removes -2kb * change doubles to floats * fixes a name * change sns idx to 25
Obvious "typo" in setting the feature bit for this recently added sensor. Already mentioned in arendst#21185 (comment)
Description:
Related issue (if applicable): fixes N/A
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass