Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IR_SEND_INVERTED and IR_SEND_USE_MODULATION compile options #10301

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

s-hadinger
Copy link
Collaborator

Description:

Add compile time options for rare IR send options:

  • IR_SEND_INVERTED: (default false) true indicates that the output IR led is inverted (LED is illuminated when GPIO is LOW rather than HIGH). Warning you can destroy your LEDs by overdriving them. Use only if you know what you are doing.
  • IR_SEND_USE_MODULATION: (default true). If true the signal is modulated to the requested frequency (generally 38KHz). If false the signal is not modulated; use it if your IR driver is already modulating the signal (quite rare).

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works on Tasmota core ESP32 V.1.0.5-rc4
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 2278d58 into arendst:development Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants