-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added StatusRetain command #11109
Added StatusRetain command #11109
Conversation
Hi, your change to the release notes is conflicting with the actual codebase. Please, delete it. |
I changed the conflicting release notes instead, is that ok? |
On hold for now as these "retain" changes are just marginal requests while I was able to keep Tasmota away of the HASS policy for many years. It adds code not used by any decent user except the famous MQTT retain afficionados... I also wonder if the retain stop code works for all status messages. |
Retain stop works for all messages, retain stop is applied juist before sending to mqtt broker. |
I would like to see this option to be merged so I can display status info on my dashboard. There is no way at this moment to send status 0 retrained. |
Why using "retain" in general? Just query the devices and you get the actual real state. |
|
And what's wrong with having a lot of MQTT traffic? It was designed exactly for that. |
@jeroenst The beauty of open source. You have made the changes you want/like. |
I can do that but than I need to merge it over and over with upstream development branch. And I think this would be a good thing if it's added. At this moment I use my own firmware, but if Tasmota is a good alternative for me I'm willing to make effort in developing Tasmota instead of my own project. |
This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR was automatically closed because of being stale. |
@arendst any chance this can be implemented? Again I try to make a status page, but again I bump into non retained messages of the tasmota, forcing me to create a kind of retain bridge which is not very nice and clean... |
@arendst the status was changed to on-hold a while ago. What can I do to get this change into the main branch? |
Add command ``StatusRetain`` (#11109)
Statusretain is working correctly in 12.1.1.2 development branch commit e3c7733 I tested with shelly 1, shelly dimmer 2, shelly 2.5, sonoff zbridge, athom power plug and Athom RGBWW bulb. Everything seems to work fine. Thank you @arendst This status page is created by: https://github.com/jeroenst/espweb/ |
Description:
Added statusretain #11067
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass