Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baudrate and serial config for modbus_bridge are now persistent #16078

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

jeroenst
Copy link
Contributor

@jeroenst jeroenst commented Jul 25, 2022

Description:

The baudrate and serial config where not saved when configuring. Also requesting the baudrate didn't return the correct baudrate. Baudrate and serial config are now saved and checked if valid before applied to serial port.

Related issue (if applicable): fixes #9586 (comment)

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.4 (N/A for TasmotaModbus)
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 41742ab into arendst:development Jul 26, 2022
@jeroenst jeroenst deleted the ModbusTCP branch July 26, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModBus RTU to TCP gateway
2 participants