MI32 legacy: fix BTHome, prepare for BLE5 #20989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Major bugfix for the BTHome parser and some small fixes/ refactoring.
Preparations for BLE5 which needs a different Arduino-framework. This was tested on the ESP32-S3 and would cost around 10kB heap. It is possible to get data from a LYDWS003MMC with PVVX firmware that is configured to use BLE5 with long range setting. Performance was mediocre and I did not really do range testings. It could be feasible to switch the ESP32-S3 and the ESP32-C6 to BLE 5 later after the switch to Arduino 3.x, but there is no hurry.
More small refactoring.
The extended web GUI will add widgets now on-the-fly without complete page reload.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass