Berry: fix file.readbytes() for large files #21657
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reading binary files into bytes in Berry leads to data corruption for large files (I did not figure out the threshold) by creating a bytes buffer of the correct size, that has correct data at the front but only holds zeros at the tail end. This fails silently and does not throw any error.
This seems to be related to the resize operation after the actual data read from the file system.
To reproduce we need a test file on the ESP, that is not too small. I used this one:
https://github.com/Staars/MockUp/blob/main/watermeter.jpg
Then load in the Berry web console:
Check the terminating bytes, which should be "FFD9" for a JPG file with:
The current version shows "0000". Tested on ESP32 and ESP32-S3.
Unrelated to this PR the C6 crashes with heap corruption:
CORRUPT HEAP: Bad head at 0x408407e8. Expected 0xabba1234 got 0x52844590
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass