Implement capability for setting CORS to a specific website instead o… #7066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendst
added
the
requested feature (hold over)
|
Implementation is kind of overkill. |
|
Reconsidering after discussion |
|
I will fix the conflicts |
|
Well at least remove the GUI parts. Takes too much code space and command line would do. |
shantur
force-pushed
the
development
branch
2 times, most recently
from
34299bd
to
1d17d03
Compare
|
@arendst : The GUI changes only need 112 bytes and allows user to setup CORS before losing access to settings. |
…f just enable for all websites
|
@arendst : I have updated my changes again to new version. Is it possible to get this merged in? |
|
@arendst : Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement capability for setting CORS to a specific website instead of just enable for all websites
Description:
This feature makes user keep device secure by just enabling CORS for a specific website / url.
Related issue (if applicable): fixes #
Checklist: