Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to build Minimal firmware with TLS support #7115

Merged
merged 2 commits into from Dec 6, 2019

Conversation

@bkmit
Copy link
Contributor

bkmit commented Dec 5, 2019

Description:

Do not undefine USE_MQTT_TLS by force for MINIMAL firmware.
This PR do not change any defaults.

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.6.1
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.
@ascillato

This comment has been minimized.

Copy link
Contributor

ascillato commented Dec 5, 2019

Sorry, Minimal firmware is not for normal usage. It is a super small version to be used just in the UPDATING process. The minimal firmware will stay in your device for just few seconds while it is updating to your full version. Adding this option will increase minimal size, restricting the available free space for the full version.

@bkmit

This comment has been minimized.

Copy link
Contributor Author

bkmit commented Dec 5, 2019

This works perfectly for me. I know what purpose of minimal was created for.
This patch do not change current project build defines, only allow to define USE_MQTT_TLS in user_config_override.h or platfomio_override.ini files if user (like me) need to.
I am using custom built TLS-enabled minimal image to do MQTT only management of all my modules.
Hope this explain why I have created this PR.

@ascillato2 ascillato2 reopened this Dec 5, 2019
@ascillato2

This comment has been minimized.

Copy link
Collaborator

ascillato2 commented Dec 5, 2019

MQTT only management of all my modules.

@bkmit Bohdan, ok, you have a valid point.

@arendst Theo, what do you think?

@arendst arendst merged commit eee16dd into arendst:development Dec 6, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ascillato

This comment has been minimized.

Copy link
Contributor

ascillato commented Dec 12, 2019

@bkmit Bohdan,

Thanks for sharing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.