Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fc: boost expansion audio output levels #875

Merged
merged 2 commits into from
Nov 21, 2022
Merged

fc: boost expansion audio output levels #875

merged 2 commits into from
Nov 21, 2022

Conversation

encoded-byte
Copy link
Contributor

@encoded-byte encoded-byte commented Nov 15, 2022 •
edited
Loading

Corrections on Famicom expansion audio output levels.

Two expansion audio systems don't require changes:

  • MMC5: it uses the same DAC as the APU (with already boosted output levels)
  • Konami VRC7: it was too loud before compared with the APU, it's fine now with no changes

This should close #869 (the "strange waveform" was discussed on discord)

@LukeUsher LukeUsher merged commit 6d17f38 into ares-emulator:master Nov 21, 2022
@encoded-byte encoded-byte deleted the apu-mixing branch December 5, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FC] NES core is much quieter than other cores and waveform looks strange
2 participants
@encoded-byte @LukeUsher