5th round of n64-systemtest fixes #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These improve accuracy and help with homebrew development, while not affecting performance much.
Fix a few tests from n64-systemtest
Fix a few tests from n64-systemtest
Currently, Ares does not model the PIF chip on its own: it looks like there was an original mistake that conflated the PI (peripheral interface, one of the components of RCP) with the PIF-NUS (a separate chip, connected to SI component of RCP via a serial bus). This refactor introduces a PIF class and moves all the related code into it. Since the class implements the Memory::IO protocol for memory accesses, it also fixes memory accesses with non standard sizes, as tested by n64-systemtest.
This was missed in the PI bus refactoring. All addresses up to 7fff'ffff are mapped to the PI bus.
rasky
force-pushed
the
turnon_address_errors
branch
from
12a7275
to
4c4f08f
Compare
LukeUsher
added a commit
that referenced
this pull request
Feb 21, 2024
23f27e2714 update ntsc-simple to current GLSL version (#549) git-subtree-dir: thirdparty/slang-shaders git-subtree-split: 23f27e2714deb610202dbcf2cebb139b5fb6d880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not many changes, but very noisy because I took the chance of properly introducing the PIF chip with its own class.
n64-systemtest status after this PR: