Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callbacks swallow exceptions #15

Open
NotAFile opened this issue Jul 29, 2018 · 2 comments
Open

Callbacks swallow exceptions #15

NotAFile opened this issue Jul 29, 2018 · 2 comments

Comments

@NotAFile
Copy link
Contributor

during the creation of piqueserver/piqueserver#361, I noticed that the enet callbacks swallow any exceptions in python space silently.

@aresch
Copy link
Owner

aresch commented Jul 30, 2018

Not really sure what we can do about that. Have you considered having your callback function schedule the code in your mainloop outside of the callback?

@NotAFile
Copy link
Contributor Author

Well, we have added a try except around it in our code. It's just a gotcha that you need that in the first place. Cython docs describe adding a try except around the code in Cython, but I have not tested if this fixes things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants