Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix breaking change ignored making the script unusable #19

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

bluesheeptoken
Copy link
Contributor

Currently the signature of the decode method supports any kwarg.

Hence, using kwarg algorithm throws a DecodeError instead of a TypeError because algorithm argument is not supported.

Correct argument name is keywords.

Reproducer:

import jwt
secret="top-secret"
token = jwt.encode({"data":"value"}, algorithm="HS512", key=secret)
import jwtcat
jwtcat.run(token, secret) # returns False with the current master, but returns True with the proposed PR

@bluesheeptoken
Copy link
Contributor Author

Gentle ping @aress31 because I know how easy it is to miss open source PRs

I know in an ideal world we should setup a CI and a unit test for this. But I guess fixing the script is good enough for now !

@aress31 aress31 merged commit 1e51467 into aress31:master Oct 11, 2022
@aress31
Copy link
Owner

aress31 commented Oct 11, 2022

Hi @bluesheeptoken - Thanks for the ping and the PR, I indeed missed the notification for this. 😁

@bluesheeptoken
Copy link
Contributor Author

I didn't expect the merge to be so fast !
Thanks for maintaining the project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants