-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedtest mod breaks Pi-Hole updates #139
Comments
Did you uninstall the mod first? |
Uninstalling via the checbox in speedtest settings did not seem to work. It said scheduled to uninstall but did nothing. I eventually uninstalled using your pipe to bash script. Here are the versions now after uninstall and pihole -r. Uninstall alone did not fix it.
Installed mod again via pipe to bash script. Same issue. I noticed while it was installing there was a message like "You are in 'detached HEAD' state. You can look around, make experimental changes.... " Is the mod pulling from the right release repo? |
Hmm, is there anything in the log file? |
Which log would that be? Happy to share. |
/var/log/pimod.log When updating/uninstalling with the buttons, the progress is written to that file. You can also view an update/uninstall in progress with It's basically the output of that command that's saved to the log. |
Got it.
|
Yeah those HEAD messages are expected because the mod had commits pushed after pihole's last release, and those additional commits aren't under a release. Could you try uninstalling the mod again with the button, and check if it's working by seeing if the log updated |
Ok, uninstalling via UI worked now, but no new entries in pimod.log since last install. Nothing. Pihole web version still remains "broken". |
You're sure the dates are the same? The log is supposed to be overwritten every time. What happens if you now run pihole restartdns |
Yes, triple checked. Last log entry even after uninstall completed was the 11:08 timestamp from above. Repeated bash install and uninstall from UI to be sure - uninstall is not written to log. Last entry is install completed. Pihole restartdns still leaves the web version "broken". |
Ok the uninstall doesn't write to the log file on my end too, that's strange! I can't replicate the broken UI though :( While I don't think there's any significant differences between arevindh's branch and mine, does the issue persist with the script here: |
Uninstalled mod.
And log:
|
And it's still broken? |
Yes indeed. Those versions should not be tampered with or it looks like they break the pihole updater. Here's the result now:
|
I'm not sure why the UI is broken for you, maybe arevindh might have an idea? Those modified versions you see are the modded files from my/arevindh's repos, and for now they aren't tagged as per arevindh (I should look into that --always) |
Perhaps this will help:
Correcting the version above does not fix it either. |
The mod seems to edit the versions, with the result that the updater does not recognise the web version. Example from my setup:
Pi-hole v5.15.5
FTL v5.21
Web Interface vDev (HEAD, v5.18.4)
Results of "pihole -up":
To fix it, and allow an upgrade, i have to repair with "pihole -r", then install the mod again. Until the next update, that is.
The text was updated successfully, but these errors were encountered: