Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Start time" column shows "Invalid date" after pihole update #158

Closed
guygrinberger opened this issue Feb 8, 2024 · 13 comments · Fixed by #157 or #159
Closed

"Start time" column shows "Invalid date" after pihole update #158

guygrinberger opened this issue Feb 8, 2024 · 13 comments · Fixed by #157 or #159

Comments

@guygrinberger
Copy link

after updating pihole using pihole -up no results are seen on the speedtest graph.
in the speedtest log I can see that the tests are running (I even cleared it so I can see it filling up) but the value of start time for each result is "Invalid date"
Screenshot 2024-02-08 at 10 45 30 AM

@arevindh
Copy link
Owner

arevindh commented Feb 8, 2024

after updating pihole using pihole -up no results are seen on the speedtest graph. in the speedtest log I can see that the tests are running (I even cleared it so I can see it filling up) but the value of start time for each result is "Invalid date" Screenshot 2024-02-08 at 10 45 30 AM

Can you give more details

  • Your OS
  • Browser and Version

@guygrinberger
Copy link
Author

@arevindh

  • OS Raspbian GNU/Linux 11 (bullseye)
  • Chrome 121.0.6167.85

@arevindh
Copy link
Owner

arevindh commented Feb 8, 2024

@arevindh

* OS Raspbian GNU/Linux 11 (bullseye)

* Chrome 121.0.6167.85
  • Are there any errors in the browser console ?
  • Can you get the API Result from the speed test list page?

@guygrinberger
Copy link
Author

guygrinberger commented Feb 8, 2024

@arevindh

  • there is a warning regarding the time
    Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged Arguments: [0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: 2024-02-07 18:31:11 IST, _f: undefined, _strict: undefined, _locale: [object Object]
  • getAllSpeedTestData example
    "data": [
        [
            1,
            "2024-02-07 18:31:11 IST",
            "2024-02-07 18:31:26 IST",
            "Cellcom",
            "93.173.102.14",
            "Cellcom Ltd.",
            0,
            3.298,
            319.044,
            99.3512,
            "https:\/\/www.speedtest.net\/result\/c\/44a40760-0b94-4f03-94a0-b8793b72fe0d"
        ],
        [
            2,
            "2024-02-07 19:00:41 IST",
            "2024-02-07 19:00:50 IST",
            "Cellcom",
            "93.173.102.14",
            "Cellcom Ltd.",
            0,
            3.244,
            313.82,
            99.3357,
            "https:\/\/www.speedtest.net\/result\/c\/7277353f-a11e-4291-8f06-903587835078"
        ],
        [
            3,
            "2024-02-07 20:00:41 IST",
            "2024-02-07 20:00:53 IST",
            "Cellcom",
            "109.186.140.144",
            "Cellcom Ltd.",
            0,
            6.663,
            312.928,
            99.8838,
            "https:\/\/www.speedtest.net\/result\/c\/1537cd0e-1ef9-4bc0-a96c-70ea74fe4258"
        ],
        [
            4,
            "2024-02-07 21:00:41 IST",
            "2024-02-07 21:00:53 IST",
            "Cellcom",
            "109.186.140.144",
            "Cellcom Ltd.",
            0,
            6.644,
            312.775,
            99.8232,
            "https:\/\/www.speedtest.net\/result\/c\/db53c9d3-a141-4f86-810a-071a4f59418d"
        ],

@ipitio
Copy link
Collaborator

ipitio commented Feb 8, 2024

Try updating with the mod script

curl -sSLN https://github.com/arevindh/pi-hole/raw/master/advanced/Scripts/speedtestmod/mod.sh | sudo bash -s up

@guygrinberger
Copy link
Author

@ipitio
still having invalid date after update

@ipitio
Copy link
Collaborator

ipitio commented Feb 11, 2024

#157 fixes all datetime issues (I hope)

@guygrinberger
Copy link
Author

@ipitio
just noticed this error while using the update script

fatal: HEAD does not point to a branch

  Error: Remote revision could not be obtained, please contact Pi-hole Support

@ipitio
Copy link
Collaborator

ipitio commented Feb 11, 2024

Yeah that's also fixed in the PR

@ChrisWNY
Copy link

ChrisWNY commented Feb 19, 2024

I just updated Pi-hole to grab the latest FTL version and had to update Speedtest as well. I'm getting nothing for bar charts after pulling the latest speedtest repo. Speedtest log looks fine, and the dates display properly. If I go into Speedtest settings to "show chart preview," just see spinning arrows. My issues are the same as those outlined by the OP otherwise.

@ipitio
Copy link
Collaborator

ipitio commented Feb 19, 2024

Hmm are there any warnings or errors in the console?

There are some values stored in LocalStorage, could you first share the values for the keys that start with "speedtest", then try clearing site data?

And what browser are you using? Do you have the same issue on another browser or device?

@ChrisWNY
Copy link

Not sure what happened but it's working now...may have been a cache issue. I generally use MS Edge or Chrome, which are similar. New bar graph looks very nice btw.

@guygrinberger
Copy link
Author

issue got resolved for me as well without any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants