Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record servlet request full url #84

Merged
merged 1 commit into from Jan 6, 2023
Merged

fix: record servlet request full url #84

merged 1 commit into from Jan 6, 2023

Conversation

mr3
Copy link
Collaborator

@mr3 mr3 commented Jan 6, 2023

FUll URL example: http://localhost:8080/commutity/httpClientTest/okHttp?k1=v1&k2=v2

The URL required for replay is /commutity/httpClientTest/okHttp?k1=v1&k2=v2, need to contain queryString

request.getContextPath() -> /commutity
request.getServletPath() -> /httpClientTest/okHttp
request.getRequestURI() -> /commutity/httpClientTest/okHttp
request.getQueryString() -> k1=v1&k2=v2
org.springframework.web.servlet.HandlerMapping.bestMatchingPattern -> /api/search/{Id}

@mr3 mr3 added the bug 🐞 Something isn't working label Jan 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

32.1% 32.1% Coverage
64.3% 64.3% Duplication

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #84 (625184b) into main (c175524) will decrease coverage by 0.03%.
The diff coverage is 18.75%.

@@             Coverage Diff              @@
##               main      #84      +/-   ##
============================================
- Coverage     21.68%   21.65%   -0.04%     
  Complexity      361      361              
============================================
  Files           136      136              
  Lines          5713     5718       +5     
  Branches        581      583       +2     
============================================
- Hits           1239     1238       -1     
- Misses         4310     4316       +6     
  Partials        164      164              
Impacted Files Coverage Δ
...ava/io/arex/inst/httpservlet/ServletExtractor.java 0.00% <0.00%> (ø)
...httpservlet/adapter/impl/ServletAdapterImplV3.java 0.00% <0.00%> (ø)
...httpservlet/adapter/impl/ServletAdapterImplV5.java 0.00% <0.00%> (ø)
.../io/arex/inst/httpservlet/ServletAdviceHelper.java 90.78% <75.00%> (-0.12%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr3 mr3 merged commit 318a761 into main Jan 6, 2023
@mr3 mr3 deleted the fix-servletUrl branch January 6, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants