Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new input structure #191

Closed
gwenchee opened this issue Feb 14, 2019 · 6 comments
Closed

new input structure #191

gwenchee opened this issue Feb 14, 2019 · 6 comments
Assignees

Comments

@gwenchee
Copy link
Collaborator

Since this #33 is proving difficult to resolve, a new typesystem is suggested:
DDCA.pdf

@gwenchee gwenchee self-assigned this Feb 14, 2019
@gwenchee gwenchee added the bug label Feb 14, 2019
@FlanFlanagan
Copy link
Contributor

So, I think it's a good start, but we run into an issue with facilities with multiple commodities. Although, I guess we could avoid that by putting a facilities down multiple times.

@gwenchee
Copy link
Collaborator Author

We decided in this #141 what we will do in the case of multiple commodities

@FlanFlanagan
Copy link
Contributor

I think you misunderstand my question. I'm referring to a facility with two fixed outputs. For example, enrichment has both a tails commodity, and a enriched fuel commodity. Both need to be tracked.

@gwenchee
Copy link
Collaborator Author

Ah i see. This was an issue even with the previous type system though?

@FlanFlanagan
Copy link
Contributor

I don't think so, because it was based on commodity. But I think the solution was the same as what I just suggested. So, I don't see any issue with this.

@gwenchee
Copy link
Collaborator Author

updated here: #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants