Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demand eq #27

Merged
merged 8 commits into from Sep 4, 2018
Merged

Demand eq #27

merged 8 commits into from Sep 4, 2018

Conversation

jbae11
Copy link
Collaborator

@jbae11 jbae11 commented Aug 31, 2018

Makes the changes from initial_demand + growth_rate to demand_eq.

Now the user can define the demand equation of the driving commodity instead of being restricted to the
(1+r)^(t) format

@@ -32,7 +32,8 @@ class NOInst(Institution):
doc="A list of commodities that the institution will manage.",
tooltip="List of commodities in the institution.",
uilabel="Commodities",
uitype="oneOrMore"
uitype="oneOrMore"
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here? Was this always missing a closing parenthesis ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I pulled from ergs/develop and it was missing a parenthesis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird

Thanks for fixing it !

self.commodity_demand[commod] = defaultdict(float)
self.fac_supply[commod] = {}
self.commod_to_fac[commod] = []
self.fresh = False

def tock(self)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing a colon here

@gwenchee
Copy link
Collaborator

gwenchee commented Sep 4, 2018

Could you change the test_cycamore.xml file to reflect the new input?

@gwenchee gwenchee merged commit 531aa50 into arfc:develop Sep 4, 2018
jbae11 referenced this pull request in jbae11/d3ploy Sep 5, 2018
Merge pull request #27 from jbae11/demand_eq
@gwenchee gwenchee mentioned this pull request Sep 7, 2018
jbae11 pushed a commit that referenced this pull request Oct 2, 2018
gwenchee pushed a commit that referenced this pull request Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants