Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.yml #283

Merged
merged 3 commits into from
Jul 25, 2019
Merged

config.yml #283

merged 3 commits into from
Jul 25, 2019

Conversation

robfairh
Copy link
Collaborator

@robfairh robfairh commented Jul 25, 2019 •
edited
Loading

Addresses issue #280
It is missing the last integration test: share_test that it is in one of the other PRs

@robfairh robfairh requested a review from gwenchee July 25, 2019 17:41
gwenchee
gwenchee approved these changes Jul 25, 2019
View reviewed changes
Copy link
Collaborator

@gwenchee gwenchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@gwenchee
Copy link
Collaborator

Ya add the share test one to the share test PR @robfairh

@gwenchee gwenchee merged commit 7785654 into arfc:master Jul 25, 2019
@robfairh robfairh mentioned this pull request Jul 25, 2019
Closed
@robfairh robfairh deleted the yml branch July 29, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwenchee gwenchee gwenchee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robfairh @gwenchee