Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one-at-a-time sensitivity analysis results #8

Merged
merged 29 commits into from
Oct 29, 2019
Merged

Conversation

gwenchee
Copy link
Collaborator

This PR contains:

  1. OAT sensitivity analysis results in jupyter notebook form for cooling-time, fleet-share, and transition-year + csv results
  2. Dakota input and python interface files + cyclus xml.in files for the explicit inventory case for each OAT sensitivity analysis
  3. READMEs

@pep8speaks
Copy link
Contributor

pep8speaks commented Oct 29, 2019

Hello @gwenchee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:1: E402 module level import not at top of file

Line 7:1: E402 module level import not at top of file

Line 7:1: E402 module level import not at top of file

Comment last updated at 2019-10-29 03:23:30 UTC

@gwenchee gwenchee requested a review from gtw2 October 29, 2019 03:27
@gwenchee gwenchee self-assigned this Oct 29, 2019
@gwenchee
Copy link
Collaborator Author

last one i promise @gtw2

@gwenchee gwenchee added the help wanted Extra attention is needed label Oct 29, 2019
@gtw2 gtw2 merged commit 5933915 into arfc:master Oct 29, 2019
Copy link
Member

@katyhuff katyhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops. I guess this got merged while I was still reviewing... here are some comments anyway...

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
dakota/oat/cooling-time/cooling-time-exp.py Show resolved Hide resolved
dakota/oat/cooling-time/README.md Show resolved Hide resolved
dakota/oat/cooling-time/ct-df-pu-sa.csv Show resolved Hide resolved
dakota/oat/fleet-share/README.md Show resolved Hide resolved
dakota/oat/fleet-share/fleet-share-exp.in Show resolved Hide resolved
@gwenchee
Copy link
Collaborator Author

I'll make a new PR addressing your comments @katyhuff

@katyhuff katyhuff mentioned this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants