Bug fix messing url parsing for obsidian links on Windows #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argenos
approved these changes
Apr 1, 2022
argenos
changed the title
|
This is a slightly cleaner solution for the windows fix in #166 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small fix for the URI parsing. Searching for "/" was failing on windows, which uses "". I pulled the OS.Path.basename function from the Zotero source, which should be platform neutral. It works fine on Windows, and I assume it works on mac and linux, but that should be tested before accepting the PR. I'd have to set everything on a virtual desktop to do that, so if you have a mac handy, that would be useful.