-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No need to pass nonce
to execute
#3
Comments
I think that makes sense if there is only one valid nonce such as the currently implemented incremental nonce. But there are other possible nonce patterns so I think that if we want to be general with the So I agree that there is no need to pass it now but I think we should keep it to anticipate future possible uses. |
@juniset Do you have examples of possible nonce patterns that would need it to be included? |
@frangio you can have a nonce where the only requirement is that the nonce of a transaction must be greater than the previous one but not necessarily by 1. Or you can have a nonce whose requirement is that the transaction parameters, as computed by the We use these 2 different nonce strategies in the Argent wallet contract on L1. |
Jus as there is no need to pass
this
,nonce
can also be omitted fromexecute
arguments, since the contract already knows what's the only validnonce
. Maybe this changes in the future if Cairo implements revert messages, then we could do something like:until that, there is no reason to have a
nonce
parameter.The text was updated successfully, but these errors were encountered: