Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account identifier supported by ArgentX accounts #87

Closed
Bal7hazar opened this issue Jan 6, 2023 · 1 comment
Closed

Account identifier supported by ArgentX accounts #87

Bal7hazar opened this issue Jan 6, 2023 · 1 comment

Comments

@Bal7hazar
Copy link

It looks like the account identifier supported by ArgentX accounts are currently the old one "0xf10dbd44", it has been updated to "0xa66bd575" (since 0.10 I think or before) in OZ contracts.

Based on this, it makes some OZ contracts (at least ERC-1155) not usable with ArgentX accounts.

A similar issue #85 has been opened and closed about ERC-721.
A discussion has also been created on OZ repo.

Not sure if it is already known or not by ArgentX team.
@Bal7hazar
Copy link
Author

Ok it seems to be supported.

https://github.com/argentlabs/argent-contracts-starknet/blob/develop/contracts/account/library.cairo#L20

sgc-code added a commit that referenced this issue Aug 18, 2023
@sgc-code
Merge pull request #87 from argentlabs/feat/update-escape-zksync
e5b4744 
Feat/update escape zksync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bal7hazar