Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include select2.full.js #134

Closed
wants to merge 3 commits into from
Closed

Include select2.full.js #134

wants to merge 3 commits into from

Conversation

@nilbus
Copy link
Contributor

@nilbus nilbus commented Sep 20, 2015

This attempts to address #131 for @PlugIN73

This should work, in theory, but I haven't had time to test it.

@nilbus
Copy link
Contributor Author

@nilbus nilbus commented Sep 20, 2015

@PlugIN73 Could you point your Gemfile to this branch to test if this works for you?

gem "select2-rails", ">= 4.0.0", github: 'nilbus/select2-rails', branch: 'full'

It should allow you to require select2.full.

@nilbus nilbus force-pushed the nilbus:full branch from ce5a609 to f2f60c9 Sep 22, 2015
@nilbus
Copy link
Contributor Author

@nilbus nilbus commented Sep 22, 2015

I confirmed in my app that this works as intended.

#= require select2.full
@PlugIN73
Copy link

@PlugIN73 PlugIN73 commented Sep 22, 2015

Oh, sorry - i didn't receive notification for first comment :( I will try today later, thank you!

@PlugIN73
Copy link

@PlugIN73 PlugIN73 commented Sep 22, 2015

@nilbus yes, it works :) Can you merge it?

@simi
Copy link
Collaborator

@simi simi commented Sep 22, 2015

Can you add README.md note?

@nilbus
Copy link
Contributor Author

@nilbus nilbus commented Sep 22, 2015

@nilbus
Copy link
Contributor Author

@nilbus nilbus commented Sep 22, 2015

@simi How does that look?

@nilbus nilbus force-pushed the nilbus:full branch from f4ce9e9 to 76cde61 Sep 23, 2015
@nilbus
Copy link
Contributor Author

@nilbus nilbus commented Sep 23, 2015

I just amended the last commit to fix a typo in the URI scheme for the select2 builds link.

@ryanharkins
Copy link

@ryanharkins ryanharkins commented Oct 3, 2015

👍

@bingxie
Copy link

@bingxie bingxie commented Nov 17, 2015

And if you want to use matcher you also need to use select2.full. Wish this one will be merged soon.

@sgranata82
Copy link

@sgranata82 sgranata82 commented Dec 2, 2015

+1

@maokomioko
Copy link

@maokomioko maokomioko commented Jan 6, 2016

Any news? :)

@jtapia
Copy link

@jtapia jtapia commented Jan 29, 2016

this allow you to use dropdownCssClass? I used your repo and it still being an issue No select2/compat/dropdownCss

@kovalevsky
Copy link

@kovalevsky kovalevsky commented Feb 9, 2016

Any news?
lgtm!

@simi
Copy link
Collaborator

@simi simi commented Apr 27, 2016

damn, I forgot to close this one

full version is already part of gem - see https://github.com/argerim/select2-rails#include-select2-rails-javascript-assets for more info

@simi simi closed this Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.