Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include select2.full.js #134

Closed
wants to merge 3 commits into from
Closed

Include select2.full.js #134

wants to merge 3 commits into from

Conversation

nilbus
Copy link
Contributor

@nilbus nilbus commented Sep 20, 2015

This attempts to address #131 for @PlugIN73

This should work, in theory, but I haven't had time to test it.

@nilbus
Copy link
Contributor Author

nilbus commented Sep 20, 2015

@PlugIN73 Could you point your Gemfile to this branch to test if this works for you?

gem "select2-rails", ">= 4.0.0", github: 'nilbus/select2-rails', branch: 'full'

It should allow you to require select2.full.

@nilbus
Copy link
Contributor Author

nilbus commented Sep 22, 2015

I confirmed in my app that this works as intended.

#= require select2.full

@PlugIN73
Copy link

Oh, sorry - i didn't receive notification for first comment :( I will try today later, thank you!

@PlugIN73
Copy link

@nilbus yes, it works :) Can you merge it?

@simi
Copy link
Collaborator

simi commented Sep 22, 2015

Can you add README.md note?

@nilbus
Copy link
Contributor Author

nilbus commented Sep 22, 2015 via email

@nilbus
Copy link
Contributor Author

nilbus commented Sep 22, 2015

@simi How does that look?

@nilbus
Copy link
Contributor Author

nilbus commented Sep 23, 2015

I just amended the last commit to fix a typo in the URI scheme for the select2 builds link.

@ryanharkins
Copy link

👍

@bingxie
Copy link

bingxie commented Nov 17, 2015

And if you want to use matcher you also need to use select2.full. Wish this one will be merged soon.

@sgranata82
Copy link

+1

@maokomioko
Copy link

Any news? :)

@jtapia
Copy link

jtapia commented Jan 29, 2016

this allow you to use dropdownCssClass? I used your repo and it still being an issue No select2/compat/dropdownCss

@kovalevsky
Copy link

Any news?
lgtm!

@simi
Copy link
Collaborator

simi commented Apr 27, 2016

damn, I forgot to close this one

full version is already part of gem - see https://github.com/argerim/select2-rails#include-select2-rails-javascript-assets for more info

@simi simi closed this Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants