Include select2.full.js #134

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
9 participants
@nilbus
Contributor

nilbus commented Sep 20, 2015

This attempts to address #131 for @PlugIN73

This should work, in theory, but I haven't had time to test it.

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Sep 20, 2015

Contributor

@PlugIN73 Could you point your Gemfile to this branch to test if this works for you?

gem "select2-rails", ">= 4.0.0", github: 'nilbus/select2-rails', branch: 'full'

It should allow you to require select2.full.

Contributor

nilbus commented Sep 20, 2015

@PlugIN73 Could you point your Gemfile to this branch to test if this works for you?

gem "select2-rails", ">= 4.0.0", github: 'nilbus/select2-rails', branch: 'full'

It should allow you to require select2.full.

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Sep 22, 2015

Contributor

I confirmed in my app that this works as intended.

#= require select2.full
Contributor

nilbus commented Sep 22, 2015

I confirmed in my app that this works as intended.

#= require select2.full
@PlugIN73

This comment has been minimized.

Show comment
Hide comment
@PlugIN73

PlugIN73 Sep 22, 2015

Oh, sorry - i didn't receive notification for first comment :( I will try today later, thank you!

Oh, sorry - i didn't receive notification for first comment :( I will try today later, thank you!

@PlugIN73

This comment has been minimized.

Show comment
Hide comment
@PlugIN73

PlugIN73 Sep 22, 2015

@nilbus yes, it works :) Can you merge it?

@nilbus yes, it works :) Can you merge it?

@simi

This comment has been minimized.

Show comment
Hide comment
@simi

simi Sep 22, 2015

Collaborator

Can you add README.md note?

Collaborator

simi commented Sep 22, 2015

Can you add README.md note?

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Sep 22, 2015

Contributor
Contributor

nilbus commented Sep 22, 2015

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Sep 22, 2015

Contributor

@simi How does that look?

Contributor

nilbus commented Sep 22, 2015

@simi How does that look?

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Sep 23, 2015

Contributor

I just amended the last commit to fix a typo in the URI scheme for the select2 builds link.

Contributor

nilbus commented Sep 23, 2015

I just amended the last commit to fix a typo in the URI scheme for the select2 builds link.

@ryanharkins

This comment has been minimized.

Show comment
Hide comment

👍

@bingxie

This comment has been minimized.

Show comment
Hide comment
@bingxie

bingxie Nov 17, 2015

And if you want to use matcher you also need to use select2.full. Wish this one will be merged soon.

bingxie commented Nov 17, 2015

And if you want to use matcher you also need to use select2.full. Wish this one will be merged soon.

@sgranata82

This comment has been minimized.

Show comment
Hide comment

+1

@maokomioko

This comment has been minimized.

Show comment
Hide comment
@maokomioko

maokomioko Jan 6, 2016

Any news? :)

Any news? :)

@jtapia

This comment has been minimized.

Show comment
Hide comment
@jtapia

jtapia Jan 29, 2016

this allow you to use dropdownCssClass? I used your repo and it still being an issue No select2/compat/dropdownCss

jtapia commented Jan 29, 2016

this allow you to use dropdownCssClass? I used your repo and it still being an issue No select2/compat/dropdownCss

@kovalevsky

This comment has been minimized.

Show comment
Hide comment
@kovalevsky

kovalevsky Feb 9, 2016

Any news?
lgtm!

Any news?
lgtm!

@simi

This comment has been minimized.

Show comment
Hide comment
@simi

simi Apr 27, 2016

Collaborator

damn, I forgot to close this one

full version is already part of gem - see https://github.com/argerim/select2-rails#include-select2-rails-javascript-assets for more info

Collaborator

simi commented Apr 27, 2016

damn, I forgot to close this one

full version is already part of gem - see https://github.com/argerim/select2-rails#include-select2-rails-javascript-assets for more info

@simi simi closed this Apr 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment