feat(#1144): allow all labels deselection in weak supervision (#1326)

closes #1144
argilla-io · Mar 28, 2022 · 6e017d4 · 6e017d4
1 parent 158fcad
commit 6e017d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/frontend/components/text-classifier/labeling-rules/RuleDefinition.vue b/frontend/components/text-classifier/labeling-rules/RuleDefinition.vue
@@ -61,10 +61,7 @@ export default {
   },
   watch: {
     async query(newValue) {
-      await this.updateCurrentRule({
-        query: newValue,
-        labels: (this.currentRule || {}).labels,
-      });
+      await this.dataset.setCurrentLabelingRule({ query: newValue });
     },
   },
   computed: {
@@ -103,7 +100,7 @@ export default {
       } else {
         await this.dataset.setCurrentLabelingRule({
           query,
-          labels: undefined,
+          labels: [],
         });
       }
       this.saved = false;

diff --git a/frontend/components/text-classifier/labeling-rules/RuleLabelsDefinition.vue b/frontend/components/text-classifier/labeling-rules/RuleLabelsDefinition.vue
@@ -153,7 +153,7 @@ export default {
       if (this.selectedLabels && queryWithLabelsIsStored) {
         return `This query with ${
           this.selectedLabels.length > 1 ? "these labels" : "this label"
-        } are already saved as rule`;
+        } is already saved as rule`;
       }
     },
     coveredRecords() {