Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Icons #1561

Closed
3 tasks done
Amelie-V opened this issue Jun 14, 2022 · 0 comments · Fixed by #1565
Closed
3 tasks done

Standardize Icons #1561

Amelie-V opened this issue Jun 14, 2022 · 0 comments · Fixed by #1565
Assignees
@leiyre @Amelie-V
Projects
Release
Milestone
v0.16.0

Comments

@Amelie-V
Copy link
Member

Amelie-V commented Jun 14, 2022 •
edited by leiyre

  • Import the free icon library to Figma https://css.gg/
  • Create icons use type
  • replace icons file

Icon use type

Button icon

  • The icon is composing the full button
  • Had to be associated with a strong tooltip

Icon inside a button

  • The icon is associated with a copy
  • No tooltip

Icon standard

  • Clickable icon
  • Should be associated with a classic tooltip

Illustrative icon

  • No clickable
  • Had to be associated with an information copy
@Amelie-V Amelie-V created this issue from a note in Release (Backlog) Jun 14, 2022
leiyre added a commit that referenced this issue Jun 16, 2022
@leiyre
feat(#1561): standardize Icons
f892662 
closes #1561

This PR includes icons from the https://css.gg/ library and renames the icons to match
@leiyre leiyre mentioned this issue Jun 16, 2022
Merged
@leiyre leiyre moved this from Backlog to Pending Review in Release Jun 17, 2022
@frascuchon frascuchon added this to the v0.16.0 milestone Jun 17, 2022
frascuchon pushed a commit that referenced this issue Jun 21, 2022
@leiyre @frascuchon
feat(#1561): standardize Icons
d3c0ddd 
closes #1561

This PR includes icons from the https://css.gg/ library and renames the icons to match
@leiyre leiyre moved this from Pending Review to Review OK in Release Jun 23, 2022
Release automation moved this from Review OK to Waiting Release Jun 23, 2022
frascuchon pushed a commit that referenced this issue Jun 23, 2022
@leiyre
feat(#1561): standardize icons (#1565)
4a928e6 
This PR includes icons from the https://css.gg/ library and renames the icons to match
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Jul 6, 2022
frascuchon pushed a commit that referenced this issue Jul 6, 2022
@leiyre @frascuchon
feat(#1561): standardize icons (#1565)
ddd6c88 
This PR includes icons from the https://css.gg/ library and renames the icons to match

(cherry picked from commit 4a928e6)
frascuchon pushed a commit that referenced this issue Jul 8, 2022
@leiyre @frascuchon
feat(#1561): standardize icons (#1565)
d35cb60 
This PR includes icons from the https://css.gg/ library and renames the icons to match

(cherry picked from commit 4a928e6)
@Amelie-V Amelie-V moved this from Ready to Release QA to Approved Release QA in Release Jul 8, 2022
frascuchon pushed a commit that referenced this issue Jul 8, 2022
@leiyre @frascuchon
feat(#1561): standardize icons (#1565)
1ff1f5a 
This PR includes icons from the https://css.gg/ library and renames the icons to match

(cherry picked from commit 4a928e6)
frascuchon pushed a commit that referenced this issue Jul 8, 2022
@leiyre @frascuchon
feat(#1561): standardize icons (#1565)
15254e7 
This PR includes icons from the https://css.gg/ library and renames the icons to match

(cherry picked from commit 4a928e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

@Amelie-V Amelie-V

Labels
None yet
Projects
No open projects
Release
Approved Release QA
Milestone
v0.16.0
Development

Successfully merging a pull request may close this issue.

feat(#1561): standardize icons argilla-io/argilla
3 participants
@frascuchon @leiyre @Amelie-V