Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Document how to setup HF OAuth #5091

Closed
dvsrepo opened this issue Jun 21, 2024 · 5 comments
Closed

[DOCS] Document how to setup HF OAuth #5091

dvsrepo opened this issue Jun 21, 2024 · 5 comments
Assignees
@sdiazlor

Comments

@dvsrepo
Copy link
Member

dvsrepo commented Jun 21, 2024

We should re-introduce the guide on how to setup HF OAuth.

Initially I'd say we can add a new section here: https://argilla-io.github.io/argilla/dev/getting_started/quickstart/

Setup Hugging Face sign-in

or something like that

wdyt @sdiazlor @davidberenstein1957 ?
@dvsrepo
Copy link
Member Author

dvsrepo commented Jun 21, 2024

we can take the opportunity to improve the previous guide!

@sdiazlor
Copy link
Contributor

IMO, I would only focus on how to set it up and remove the 'create a dataset' section, as it's the same as the quickstart and can create confusion about whether they are different methods.

@dvsrepo
Copy link
Member Author

dvsrepo commented Jun 21, 2024

IMO, I would only focus on how to set it up and remove the 'create a dataset' section, as it's the same as the quickstart and can create confusion about whether they are different methods.

Fully agree!

@davidberenstein1957
Copy link
Member

Perhaps related: #5097

@davidberenstein1957 davidberenstein1957 added this to the v2.0.0 milestone Jun 25, 2024
@sdiazlor sdiazlor mentioned this issue Jun 28, 2024
Merged
@nataliaElv nataliaElv mentioned this issue Jul 2, 2024
Closed
sdiazlor added a commit that referenced this issue Jul 5, 2024
@sdiazlor @davidberenstein1957
docs/document how to setup hf oauth (#5125)
b31e607 
# Pull Request Template
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->

COMMENTS:
- I'm not sure about the index shown due to the installation.md file (as
it encompass the library installation, mention the server and some
developer info), maybe it would be useful to also add a basic docker.md
as they are the two basic ways of deploying.
- I also thought of mentioning that they can use Oauth with other apps,
but while we don't add other type of deployments (community ones) I
decided not to confuse.

Closes #5091 

**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->

- Documentation update

**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->
mkdocs serve

**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->

- I added relevant documentation

---------

Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
@nataliaElv
Copy link
Member

I'm closing and removing the 2.0 milestone, since this is already merged with main 🙂

@nataliaElv nataliaElv removed this from the v2.0.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdiazlor sdiazlor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dvsrepo @davidberenstein1957 @nataliaElv @sdiazlor