Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LabelModel] Use classification_report for the LabelModel.score method #995

Closed
dcfidalgo opened this issue Jan 18, 2022 · 2 comments · Fixed by #1150
Closed

[LabelModel] Use classification_report for the LabelModel.score method #995

dcfidalgo opened this issue Jan 18, 2022 · 2 comments · Fixed by #1150
Assignees
@dcfidalgo
Labels
type: documentation Improvements or additions to documentation
Projects
Release

Comments

@dcfidalgo
Copy link
Contributor

Return the str of the sklearn.metrics.classification_report by default, add an output_dict parameter to be able to output a dict instead.
Show this feature in our wl guide/tutorial.
@dcfidalgo dcfidalgo self-assigned this Jan 18, 2022
@dcfidalgo dcfidalgo added type: documentation Improvements or additions to documentation labeling labels Jan 18, 2022
@dcfidalgo dcfidalgo added this to Backlog in Release via automation Jan 18, 2022
@dcfidalgo dcfidalgo mentioned this issue Jan 18, 2022
Closed
@frascuchon
Copy link
Member

Can we close this PR ?????

@dcfidalgo
Copy link
Contributor Author

Naa, still pending, it's on my todo, I'll try to open a PR this week.

@dcfidalgo dcfidalgo mentioned this issue Feb 14, 2022
Merged
@frascuchon frascuchon moved this from Backlog to Planified in Release Feb 15, 2022
@dcfidalgo dcfidalgo moved this from Planified to Ready to DEV QA in Release Feb 16, 2022
dcfidalgo pushed a commit that referenced this issue Feb 16, 2022
refactor(#995): use sklearn classification_report for label model sco…
fbff02d 
…res (#1150)

* refactor: use classification_report to compute label model metrics

* test: adapt tests

* feat: default to dict output

* test: fix test

* docs: show output_str argument in guide, improve model evaluations

* test: add small test

* fix: add missing import
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Mar 3, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Mar 3, 2022
frascuchon pushed a commit that referenced this issue Mar 3, 2022
@frascuchon
refactor(#995): use sklearn classification_report for label model sco…
6eb33b7 
…res (#1150)

* refactor: use classification_report to compute label model metrics

* test: adapt tests

* feat: default to dict output

* test: fix test

* docs: show output_str argument in guide, improve model evaluations

* test: add small test

* fix: add missing import

(cherry picked from commit fbff02d)
@dcfidalgo dcfidalgo moved this from Ready to Release QA to Approved Release QA in Release Mar 3, 2022
frascuchon pushed a commit that referenced this issue Mar 4, 2022
@frascuchon
refactor(#995): use sklearn classification_report for label model sco…
ba0fb7b 
…res (#1150)

* refactor: use classification_report to compute label model metrics

* test: adapt tests

* feat: default to dict output

* test: fix test

* docs: show output_str argument in guide, improve model evaluations

* test: add small test

* fix: add missing import

(cherry picked from commit fbff02d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcfidalgo dcfidalgo

Labels
type: documentation Improvements or additions to documentation
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(#995): use sklearn classification_report for label model scores argilla-io/argilla
2 participants
@frascuchon @dcfidalgo