Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(statics): handle 404 errors for static files #1006

Merged
merged 1 commit into from Jan 20, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/rubrix/server/commons/static_rewrite.py
Expand Up @@ -12,8 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
from typing import Union

from fastapi.staticfiles import StaticFiles
from starlette.exceptions import HTTPException
from starlette.responses import Response
from starlette.types import Scope

Expand All @@ -22,7 +24,17 @@ class RewriteStaticFiles(StaticFiles):
"""Simple server rewrite implementation for SPI apps"""

async def get_response(self, path: str, scope: Scope) -> Response:
response = await super().get_response(path, scope)
if self.html and response.status_code == 404:
response = await super().get_response(path="", scope=scope)
return response
try:
response = await super().get_response(path, scope)
return await self._handle_response(response, scope)
except HTTPException as ex:
return await self._handle_response(ex, scope)

async def _handle_response(
self, response_or_error: Union[Response, HTTPException], scope
):
if self.html and (response_or_error.status_code == 404):
return await super().get_response(path="", scope=scope)
if isinstance(response_or_error, HTTPException):
raise response_or_error
return response_or_error