Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1192): disable ssl verify for elasticsearch http client #1193

Merged
merged 1 commit into from Feb 23, 2022

Conversation

frascuchon
Copy link
Member

This PR just allows disable http ssl client verification (for elasticsearch/opensearch connection) by setting the environment variable:

RUBRIX_ELASTICSEARCH_SSL_VERIFY=False

This is strongly discouraged for production environments, but can be used for quick testing of non-secure environments.

@frascuchon frascuchon self-assigned this Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1193 (301d669) into master (1803531) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         124      124           
  Lines        4955     4956    +1     
=======================================
+ Hits         4707     4708    +1     
  Misses        248      248           
Flag Coverage Δ
pytest 94.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/commons/es_wrapper.py 88.46% <100.00%> (ø)
src/rubrix/server/commons/settings.py 88.88% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1803531...301d669. Read the comment docs.

@frascuchon frascuchon merged commit 007688f into master Feb 23, 2022
@frascuchon frascuchon deleted the feat/disable-ssl-verify branch February 23, 2022 09:39
frascuchon added a commit that referenced this pull request Mar 3, 2022
frascuchon added a commit that referenced this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Es connection] Allow disable ssl verification for elasticsearch connection
2 participants