feat(#1225): create iob tags from record spans #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
commented
Mar 4, 2022
|
@dcfidalgo Any idea about how to define as read-only the |
frascuchon
force-pushed
the
feature/build-iob-tags-in-client
branch
from
8d5fdec
to
54a5588
Compare
|
Finally I didn't found a way to keep text and tokens inmutables. So the tokens/chars map will be dynamically computed every time. I've include a cache resolution to avoid extra computations. Take a look @dcfidalgo |
Codecov Report
@@ Coverage Diff @@
## master #1226 +/- ##
==========================================
- Coverage 94.88% 94.84% -0.04%
==========================================
Files 127 127
Lines 5391 5449 +58
==========================================
+ Hits 5115 5168 +53
- Misses 276 281 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dcfidalgo
force-pushed
the
feature/build-iob-tags-in-client
branch
from
54a5588
to
c0b5900
Compare
|
@frascuchon Have a look at c0b5900 for making text and tokens immutable. Maybe we could move the "immutability" of |
dcfidalgo
approved these changes
Mar 7, 2022
frascuchon
added a commit
that referenced
this pull request
Mar 25, 2022
* feat(#1225): create iob tags from record spans * test: add tests * refactor: dynamic tokens map with text/tokens mutability * chore: naming * feat: make text and tokens immutable * chore: adapt to inmutable text and tokens * test: fix tests * test: fixing tests Co-authored-by: dcfidalgo <david@recogn.ai> (cherry picked from commit 07b895d)
frascuchon
added a commit
that referenced
this pull request
Mar 28, 2022
* feat(#1225): create iob tags from record spans * test: add tests * refactor: dynamic tokens map with text/tokens mutability * chore: naming * feat: make text and tokens immutable * chore: adapt to inmutable text and tokens * test: fix tests * test: fixing tests Co-authored-by: dcfidalgo <david@recogn.ai> (cherry picked from commit 07b895d)
frascuchon
added a commit
that referenced
this pull request
Mar 28, 2022
* feat(#1225): create iob tags from record spans * test: add tests * refactor: dynamic tokens map with text/tokens mutability * chore: naming * feat: make text and tokens immutable * chore: adapt to inmutable text and tokens * test: fix tests * test: fixing tests Co-authored-by: dcfidalgo <david@recogn.ai> (cherry picked from commit 07b895d)
frascuchon
added a commit
that referenced
this pull request
Mar 30, 2022
* feat(#1225): create iob tags from record spans * test: add tests * refactor: dynamic tokens map with text/tokens mutability * chore: naming * feat: make text and tokens immutable * chore: adapt to inmutable text and tokens * test: fix tests * test: fixing tests Co-authored-by: dcfidalgo <david@recogn.ai> (cherry picked from commit 07b895d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we include client functionality for generate iob tags from record spans definitions. This will help for generate training dataset for huggingface models training
See #1225