Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(#945): unify query to elasticsearch generation #1230

Merged
merged 3 commits into from Mar 8, 2022

Conversation

frascuchon
Copy link
Member

This PR centralizes all elasticsearch query generation from query datamodel in query builder. This will simplify extension or migrations to new search data model.

@frascuchon frascuchon self-assigned this Mar 7, 2022
@frascuchon frascuchon added the area: server Indicates that an issue or pull request is related to the server label Mar 7, 2022
@frascuchon frascuchon added this to In progress in Release via automation Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1230 (ccad663) into master (07b895d) will decrease coverage by 0.17%.
The diff coverage is 82.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
- Coverage   94.84%   94.67%   -0.18%     
==========================================
  Files         127      127              
  Lines        5449     5444       -5     
==========================================
- Hits         5168     5154      -14     
- Misses        281      290       +9     
Flag Coverage Δ
pytest 94.67% <82.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/tasks/commons/metrics/commons.py 100.00% <ø> (ø)
src/rubrix/server/tasks/text2text/api/model.py 98.43% <ø> (-0.20%) ⬇️
...brix/server/tasks/text_classification/api/model.py 99.41% <ø> (-0.03%) ⬇️
...rix/server/tasks/token_classification/api/model.py 98.18% <ø> (-0.10%) ⬇️
src/rubrix/server/commons/es_helpers.py 82.19% <60.00%> (-4.24%) ⬇️
src/rubrix/server/tasks/search/query_builder.py 83.63% <96.00%> (+9.44%) ⬆️
src/rubrix/server/tasks/commons/api/model.py 96.35% <100.00%> (+0.05%) ⬆️
src/rubrix/server/tasks/search/model.py 100.00% <100.00%> (+4.34%) ⬆️
...ks/text_classification/service/labeling_service.py 99.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b895d...ccad663. Read the comment docs.

@frascuchon frascuchon force-pushed the refactor/unify-es-search-generation branch from 176d2d4 to ccad663 Compare March 8, 2022 09:15
Release automation moved this from In progress to Review Mar 8, 2022
@frascuchon frascuchon merged commit 630091f into master Mar 8, 2022
Release automation moved this from Review to Ready to DEV QA Mar 8, 2022
@frascuchon frascuchon deleted the refactor/unify-es-search-generation branch March 8, 2022 16:19
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Mar 8, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to DEV QA in Release Mar 8, 2022
@frascuchon frascuchon moved this from Ready to DEV QA to Ready to Release QA in Release Mar 25, 2022
frascuchon added a commit that referenced this pull request Mar 25, 2022
* refactor(#945): unify query to elasticsearch generation

* test: update tests

* chore: add TODOs

(cherry picked from commit 630091f)

fix(#1259): apply QueryRange config to es query (#1260)

Closes #1259
(cherry picked from commit 6dea7b2)
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Mar 28, 2022
frascuchon added a commit that referenced this pull request Mar 28, 2022
* refactor(#945): unify query to elasticsearch generation

* test: update tests

* chore: add TODOs

(cherry picked from commit 630091f)

fix(#1259): apply QueryRange config to es query (#1260)

Closes #1259
(cherry picked from commit 6dea7b2)
frascuchon added a commit that referenced this pull request Mar 28, 2022
* refactor(#945): unify query to elasticsearch generation

* test: update tests

* chore: add TODOs

(cherry picked from commit 630091f)

fix(#1259): apply QueryRange config to es query (#1260)

Closes #1259
(cherry picked from commit 6dea7b2)
frascuchon added a commit that referenced this pull request Mar 30, 2022
* refactor(#945): unify query to elasticsearch generation

* test: update tests

* chore: add TODOs

(cherry picked from commit 630091f)

fix(#1259): apply QueryRange config to es query (#1260)

Closes #1259
(cherry picked from commit 6dea7b2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Indicates that an issue or pull request is related to the server
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants