fix(workspaces): superuser with empty workspace #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1288 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 129 129
Lines 5800 5802 +2
=======================================
+ Hits 5451 5453 +2
Misses 349 349
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
frascuchon
added
the
type: bug
frascuchon
added a commit
that referenced
this pull request
Mar 25, 2022
(cherry picked from commit cd2b5c9) fix(workspaces): superuser with empty workspace (#1288) (cherry picked from commit 4b1ab45) refactor(workspaces): find datasets without workspace for superusers (#1290) * refactor(workspaces): find datasets without workspace for superusers * chore: add Optional to owner field definition (cherry picked from commit 4e2aa1b)
frascuchon
added a commit
that referenced
this pull request
Mar 25, 2022
(cherry picked from commit cd2b5c9) fix(workspaces): superuser with empty workspace (#1288) (cherry picked from commit 4b1ab45) refactor(workspaces): find datasets without workspace for superusers (#1290) * refactor(workspaces): find datasets without workspace for superusers * chore: add Optional to owner field definition (cherry picked from commit 4e2aa1b)
frascuchon
added a commit
that referenced
this pull request
Mar 28, 2022
(cherry picked from commit cd2b5c9) fix(workspaces): superuser with empty workspace (#1288) (cherry picked from commit 4b1ab45) refactor(workspaces): find datasets without workspace for superusers (#1290) * refactor(workspaces): find datasets without workspace for superusers * chore: add Optional to owner field definition (cherry picked from commit 4e2aa1b)
frascuchon
added a commit
that referenced
this pull request
Mar 28, 2022
(cherry picked from commit cd2b5c9) fix(workspaces): superuser with empty workspace (#1288) (cherry picked from commit 4b1ab45) refactor(workspaces): find datasets without workspace for superusers (#1290) * refactor(workspaces): find datasets without workspace for superusers * chore: add Optional to owner field definition (cherry picked from commit 4e2aa1b)
frascuchon
added a commit
that referenced
this pull request
Mar 30, 2022
(cherry picked from commit cd2b5c9) fix(workspaces): superuser with empty workspace (#1288) (cherry picked from commit 4b1ab45) refactor(workspaces): find datasets without workspace for superusers (#1290) * refactor(workspaces): find datasets without workspace for superusers * chore: add Optional to owner field definition (cherry picked from commit 4e2aa1b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super user cannot see non-workspaced datasets (error 404). This PR fixes that.