Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#1247): label models predict method returns DatasetForTextClassification #1442

Merged
merged 2 commits into from Apr 29, 2022
Merged

feat(#1247): label models predict method returns DatasetForTextClassification #1442

merged 2 commits into from Apr 29, 2022

Conversation

dcfidalgo
Copy link
Contributor

Closes #1247

With this PR the label model predict method returns now a DatasetForTextClassification instead of a list of records.
It also updates the documentation (tutorials) accordingly improving it a bit.

@dcfidalgo dcfidalgo mentioned this pull request Apr 28, 2022
Closed
@dcfidalgo dcfidalgo self-assigned this Apr 28, 2022
@dcfidalgo dcfidalgo added type: documentation Improvements or additions to documentation labeling labels Apr 28, 2022
@dcfidalgo dcfidalgo added this to In progress in Release via automation Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited

Codecov Report

Merging #1442 (429dd3c) into master (1114d41) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1442      +/-   ##
==========================================
- Coverage   95.46%   95.46%   -0.01%     
==========================================
  Files         114      114              
  Lines        5794     5793       -1     
==========================================
- Hits         5531     5530       -1     
  Misses        263      263
Flag Coverage Δ
pytest 95.46% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ubrix/labeling/text_classification/label_models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1114d41...429dd3c. Read the comment docs.

Release automation moved this from In progress to Review OK Apr 29, 2022
@dcfidalgo dcfidalgo merged commit 559593a into master Apr 29, 2022
Release automation moved this from Review OK to Waiting Release Apr 29, 2022
@dcfidalgo dcfidalgo deleted the feat/return_dataset_instead_of_list branch April 29, 2022 12:13
@frascuchon frascuchon removed this from Waiting Release in Release May 4, 2022
frascuchon pushed a commit that referenced this pull request May 4, 2022
@frascuchon
feat(#1247): label models predict method returns DatasetForTextClassi…
bb98ab5 
…fication (#1442)

* feat: return DatasetForTextClassification instead of list of records

* docs: update/improve weak label tutorials

(cherry picked from commit 559593a)
frascuchon pushed a commit that referenced this pull request May 10, 2022
@frascuchon
feat(#1247): label models predict method returns DatasetForTextClassi…
42ca1be 
…fication (#1442)

* feat: return DatasetForTextClassification instead of list of records

* docs: update/improve weak label tutorials

(cherry picked from commit 559593a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

Assignees

@dcfidalgo dcfidalgo

Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LabelModels] The LabelModel.predict should optionally return a numpy array
2 participants
@dcfidalgo @frascuchon